FrSky new sensors support #5766
Conversation
|
I have added some more sensors. There is an issue with the gas flow sensor : we do not have flow unit. Adding a flow unit would require conversion (because if added after text, if would fail validity test < UNIT_FIRST_VIRTUAL in a couple of places) |
radio/src/telemetry/frsky_sport.cpp
Outdated
| { ESC_RPM_CONS_FIRST_ID, ESC_RPM_CONS_LAST_ID, 0, ZSTR_ESC_RPM, UNIT_RPMS, 0 }, | ||
| { ESC_RPM_CONS_FIRST_ID, ESC_RPM_CONS_LAST_ID, 1, ZSTR_ESC_CONSUMPTION, UNIT_MAH, 0 }, | ||
| { ESC_TEMPERATURE_FIRST_ID, ESC_TEMPERATURE_LAST_ID, 0, ZSTR_ESC_TEMP, UNIT_CELSIUS, 0 }, | ||
| { GASSUIT_TEMP_FIRST_ID, GASSUIT_TEMP_LAST_ID, 0, ZSTR_TEMP1, UNIT_CELSIUS, 0 }, |
There was a problem hiding this comment.
I am not sure we can reuse ZSTR in multiple sensors here (unless we decide that GasSuite is not used with a temperature sensor)
radio/src/telemetry/frsky_sport.cpp
Outdated
| else if (id >= ESC_TEMPERATURE_FIRST_ID && id <= ESC_TEMPERATURE_LAST_ID) { | ||
| sportProcessTelemetryPacket(id, 0, instance, data & 0x00ff); | ||
| } | ||
| else if (id >= GASSUIT_TEMP_FIRST_ID && id <= GASSUIT_TEMP_LAST_ID) { |
There was a problem hiding this comment.
those 2 cases can be combined (as I did for ESC), but perhaps the compiler does the optimization on his own
in fact, the comment is right, there are 2 sensors but you didn't combine them
|
Thanks again for your help @3djc this seems perfect to me, we just need some sensors to test the feature. I will try to have a sensors set for you |
Don't merge it now, some other sensors are still missing